-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flyte docs build directions #4862
Conversation
Signed-off-by: Peeter Piegaze <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4862 +/- ##
==========================================
+ Coverage 58.97% 59.24% +0.26%
==========================================
Files 645 567 -78
Lines 55162 44559 -10603
==========================================
- Hits 32533 26398 -6135
+ Misses 20054 15766 -4288
+ Partials 2575 2395 -180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggestions, otherwise LGTM
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Peeter Piegaze <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Peeter Piegaze <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Peeter Piegaze <[email protected]>
* Update flyte docs build directions Signed-off-by: Peeter Piegaze <[email protected]> * Update docs/community/contribute.rst Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Peeter Piegaze <[email protected]> * Update docs/community/contribute.rst Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Peeter Piegaze <[email protected]> * Update docs/community/contribute.rst Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Peeter Piegaze <[email protected]> --------- Signed-off-by: Peeter Piegaze <[email protected]> Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
* Update flyte docs build directions Signed-off-by: Peeter Piegaze <[email protected]> * Update docs/community/contribute.rst Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Peeter Piegaze <[email protected]> * Update docs/community/contribute.rst Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Peeter Piegaze <[email protected]> * Update docs/community/contribute.rst Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Peeter Piegaze <[email protected]> --------- Signed-off-by: Peeter Piegaze <[email protected]> Co-authored-by: Nikki Everett <[email protected]>
Update directions in contributing guide for building Flyte docs to align with new monodocs build system